Favor local config value on enable global namespace #2368
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wxing1292
approved these changes
Jan 12, 2022
yiminc
approved these changes
Jan 12, 2022
yux0
added a commit
that referenced
this pull request
Jan 12, 2022
* Favor config value in enable global namespace * Add comment * Update cluster metadata info if enable namespace changed
yux0
added a commit
that referenced
this pull request
Jan 12, 2022
* Favor config value in enable global namespace * Add comment * Update cluster metadata info if enable namespace changed
yux0
added a commit
that referenced
this pull request
Jan 12, 2022
yux0
added a commit
that referenced
this pull request
Jan 21, 2022
* Favor config value in enable global namespace * Add comment * Update cluster metadata info if enable namespace changed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changed?
Update enable namespace config value in storage.
Why?
Enable namespace can be configurable and we should update the value.
How did you test it?
Unit tests
Potential risks
N/A
Is hotfix candidate?
Yes. This is to cover a case where a multi-cluster initialized with global namespace as false.