Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix fake cluster for empty version #2376

Merged
merged 1 commit into from
Jan 27, 2022
Merged

Fix fake cluster for empty version #2376

merged 1 commit into from
Jan 27, 2022

Conversation

yiminc
Copy link
Member

@yiminc yiminc commented Jan 13, 2022

What changed?
Correctly handle FakeClusterForEmptyVersion and added integration test for ns migration

Why?
Added integration test for migration.

How did you test it?
New integration test

Potential risks
No

Is hotfix candidate?
No

@yiminc yiminc requested a review from a team January 13, 2022 17:22
@yiminc yiminc force-pushed the integration_test_migration branch from d4b7b52 to 6ebf2ec Compare January 20, 2022 21:16
@yiminc yiminc closed this Jan 21, 2022
@yiminc yiminc reopened this Jan 21, 2022
@yiminc yiminc force-pushed the integration_test_migration branch from 6ebf2ec to 6c4376b Compare January 21, 2022 04:30
@yiminc yiminc requested review from yycptt and yux0 January 21, 2022 04:30
wxing1292
wxing1292 approved these changes Jan 21, 2022
View reviewed changes
Copy link
Contributor

@wxing1292 wxing1292 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

plz check add additional logic in
clientBean.GetRemoteAdminClient(clusterName)
this should return an noop client for version 0 cluster

yux0
yux0 reviewed Jan 22, 2022
View reviewed changes
common/cluster/metadata.go Outdated Show resolved Hide resolved
yux0
yux0 reviewed Jan 22, 2022
View reviewed changes
client/admin/noopClient.go Outdated Show resolved Hide resolved
yux0
yux0 reviewed Jan 22, 2022
View reviewed changes
common/cluster/metadata.go Outdated Show resolved Hide resolved
@yiminc yiminc force-pushed the integration_test_migration branch from 5a3ee38 to d9d0230 Compare January 27, 2022 00:26
@yiminc yiminc merged commit b87d605 into temporalio:master Jan 27, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@paulnpdev paulnpdev paulnpdev left review comments

@wxing1292 wxing1292 wxing1292 approved these changes

@yux0 yux0 yux0 approved these changes

@yycptt yycptt Awaiting requested review from yycptt

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@yiminc @yux0 @wxing1292 @paulnpdev