Update OpenTelemetry to v1.2.0 and OpenTelemetry Metrics to v0.25.0 #2385
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changed?
Updated OpenTelemetry to v1.2.0, and its corresponding metrics library to v0.25.0.
Why?
To update OpenTelemetry to the version that the Go SDK uses. See #2321 for more context.
How did you test it?
Ensured tests passed, with instructions at https://github.com/temporalio/temporal/blob/master/CONTRIBUTING.md#run-tests.
Potential risks
Worst case, this would cause metrics to break in production. The risk is low, however, as the breaking changes from v1.1.0 -> v1.2.0 (and v0.24.0 -> v0.25.0) were just renames.
Is hotfix candidate?
No.