Switch force-replication to scan over visibility #2386
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
paulnpdev
reviewed
Jan 19, 2022
alexshtin
approved these changes
Jan 20, 2022
service/worker/migration/workflow.go
Outdated
| for i := startIndex; i < len(request.Executions); i++ { | ||
| rateLimiter.Wait(ctx) | ||
| we := request.Executions[i] | ||
| err := a.genReplicationTaskForOneWorkflow(ctx, definition.NewWorkflowKey(request.NamespaceID, we.WorkflowId, we.RunId)) |
There was a problem hiding this comment.
Suggested change
| err := a.genReplicationTaskForOneWorkflow(ctx, definition.NewWorkflowKey(request.NamespaceID, we.WorkflowId, we.RunId)) | |
| err := a.generateWorkflowReplicationTask(ctx, definition.NewWorkflowKey(request.NamespaceID, we.WorkflowId, we.RunId)) |
please...
alexshtin
reviewed
Jan 20, 2022
|
|
||
| defaultListWorkflowsPageSize = 1000 | ||
| defaultPageCountPerExecution = 200 | ||
| maxPageCountPerExecution = 1000 | ||
|
|
||
| minimumAllowedLaggingSeconds = 5 | ||
| minimumHandoverTimeoutSeconds = 30 |
There was a problem hiding this comment.
Not a part of this PR, but why not time.Duration?
There was a problem hiding this comment.
It is easier to write in JSON format just a number than time.Duration. But yes, it can be updated to use time.Duration.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changed?
Scan visibility instead of core execution table.
Why?
Scan table API on SQL persistence is not implemented and also to avoid tombstone issue on Cassandra.
How did you test it?
Manual test. Also integration test (will be in follow up PR).
Potential risks
No
Is hotfix candidate?
No