Remove go mod init from dockerize build in base-server.Dockerfile
#2393
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Dockerize moved from using Glock to Go modules and introduced go.mod and go.sum files into the repository. Therefore, the Go module initialization command has to be removed from the `base-server` Dockerfile as it breaks the build. See: jwilder/dockerize@6f92b85
|
|
|
Wow, |
alexshtin
approved these changes
Jan 21, 2022
alexshtin
reviewed
Jan 21, 2022
| @@ -8,7 +8,6 @@ RUN apk add --update --no-cache \ | |||
| RUN mkdir -p /xsrc && \ | |||
| git clone https://github.com/jwilder/dockerize.git && \ | |||
| cd dockerize && \ | |||
| go mod init github.com/jwilder/dockerize && \ | |||
| go mod tidy && \ | |||
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Dockerize moved from using Glock to Go modules and introduced go.mod and go.sum files into the repository.
Therefore, the Go module initialization command has to be removed from the
base-serverDockerfile as it breaks the build.See: jwilder/dockerize@6f92b85
What changed?
The
go mod initcommand was removed from the build of thedockerizetool in thebase-serverimage.Why?
A clean build of the
base-serverimage fails.How did you test it?
I've run the build and checked the server locally.
Potential risks
The build of Docker images based on the
base-serverimage will fail:temporal-serverandtemporal-tctl.Is hotfix candidate?
No