Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Build docker image using Buildkite #2400

Merged
merged 2 commits into from
Jan 21, 2022

Conversation

alexshtin
Copy link
Member

@alexshtin alexshtin commented Jan 21, 2022

What changed?
Build docker image using Buildkite.

Why?
ci-build target builds project with CGO_ENABLED=1 but docker images are getting build without cgo. Adding extra validation step which build docker image (without publishing) and validates that:

  1. Project can be built without cgo,
  2. Dockerfile is valid and all its dependencies exist.

How did you test it?
With Buildkite.

Potential risks
No risks.

Is hotfix candidate?
No.

@alexshtin alexshtin requested a review from a team January 21, 2022 06:08
@alexshtin alexshtin enabled auto-merge (squash) January 21, 2022 06:39
@alexshtin alexshtin merged commit aa69178 into temporalio:master Jan 21, 2022
@alexshtin alexshtin deleted the feature/buildkite-docker-image branch January 21, 2022 06:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants