Add validation for invalid starttime filter for standard visibility #2401
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alexshtin
approved these changes
Jan 21, 2022
Ardagan
pushed a commit
that referenced
this pull request
Jan 21, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changed?
Return errors when user specifies comparison filter for
StartTimefor standard visibility.Why?
Right now it will panic due to
nilpointer exception. Technically it is possible to process comparison filter forStartTime, but we decided to only support equals comparison for all the standard queries. Open this up just forStartTimeadds unnecessary complexity with minimum benefit. User can easily translate a comparison expression to aBETWEEN ... AND ...expression forStartTimewhich is currently supported.How did you test it?
Unit test.
Potential risks
No risks.
Is hotfix candidate?
No.