Allow update initial failover version and version increment #2425
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…able global namespace
yiminc
reviewed
Jan 27, 2022
| @@ -206,9 +206,16 @@ func (m *clusterMetadataManagerImpl) convertInternalGetClusterMetadataResponse( | |||
|
|
|||
| // immutableFieldsChanged returns true if any of immutable fields changed. | |||
| func immutableFieldsChanged(old persistencespb.ClusterMetadata, cur persistencespb.ClusterMetadata) bool { | |||
| return (old.ClusterName != "" && old.ClusterName != cur.ClusterName) || | |||
| if (old.ClusterName != "" && old.ClusterName != cur.ClusterName) || | |||
There was a problem hiding this comment.
what about clusterName? Should you allow clusterName change if globNamespace is not enabled yet on current cluster.
There was a problem hiding this comment.
Cluster name is also stored in namespace table so probably not a good idea to change it?
There was a problem hiding this comment.
Yes. This is the tricky one. We need some offline discussion.
yiminc
approved these changes
Jan 27, 2022
| @@ -206,9 +206,16 @@ func (m *clusterMetadataManagerImpl) convertInternalGetClusterMetadataResponse( | |||
|
|
|||
| // immutableFieldsChanged returns true if any of immutable fields changed. | |||
| func immutableFieldsChanged(old persistencespb.ClusterMetadata, cur persistencespb.ClusterMetadata) bool { | |||
| return (old.ClusterName != "" && old.ClusterName != cur.ClusterName) || | |||
| if (old.ClusterName != "" && old.ClusterName != cur.ClusterName) || | |||
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changed?
Allow update initial failover version and version increment if not enable global namespace
Why?
Give it a chance to update the failover version and version increment.
How did you test it?
Tested locally
Potential risks
Is hotfix candidate?