Fix TQ user latency not reported correctly #2431
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Ardagan
force-pushed
the
PatchTQUserLatency
branch
2 times, most recently
from
d788809 to
fa295af
Compare
Ardagan
force-pushed
the
PatchTQUserLatency
branch
from
fa295af to
8146eb1
Compare
yiminc
approved these changes
Jan 29, 2022
| @@ -271,11 +271,13 @@ func (t *taskProcessor) processTaskOnce( | |||
| } | |||
|
|
|||
| ctx := context.Background() | |||
| ctx = metrics.AddMetricsContext(ctx) | |||
There was a problem hiding this comment.
was this a regression or was it never wired up?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changed?
Added metrics context to golang context for proper metrics propagation.
Why?
Fix incorrectly reported metric.
How did you test it?
manual tests
Potential risks
N/A
Is hotfix candidate?
Yes