Convert ConverterError to InvalidArgument in standard visibility parser #2437
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
another approach is to have a central place (grpc interceptor) that convert any internal error type to public error type. |
yiminc
approved these changes
Jan 30, 2022
meiliang86
approved these changes
Jan 30, 2022
|
We started the discussion on how to generate, pass, and handle errors in a right way but I don't remember that we finished it. |
alexshtin
force-pushed
the
feature/fix-converter-error
branch
from
f3f0b1f to
1cf5370
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changed?
Convert
ConverterErrortoInvalidArgumentin standard visibility parser.Why?
Go errors are converted to unknown error which is retryable by SDK. This leads to bad experience when user makes a mistake in
Queryparameter (or--queryflag intctl) and instead of getting appropriate error with message it gets "context deadline exceeded" error because SDK retries the error for 10 seconds and then times out.How did you test it?
Run
tctl wf list --querymanually.Potential risks
No risks.
Is hotfix candidate?
No.