Remove unused resource struct #2444
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wxing1292
reviewed
Feb 1, 2022
| @@ -218,225 +218,225 @@ func NewTest( | |||
| } | |||
|
|
|||
There was a problem hiding this comment.
should resourceTest.go be removed?
There was a problem hiding this comment.
No. This contains the actual Test struct that is used by other unit tests. It's not related to the resource struct./
We could change the name of the package. But I'll leave it for now.
wxing1292
approved these changes
Feb 1, 2022
yycptt
approved these changes
Feb 1, 2022
Ardagan
approved these changes
Feb 1, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changed?
Remove unused code.
Why?
How did you test it?
Potential risks
Is hotfix candidate?