Add more test for namespace promotion #2450
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
yiminc
force-pushed
the
test_migration
branch
2 times, most recently
from
e70b2ea to
1cc50e9
Compare
yux0
reviewed
Feb 2, 2022
yux0
approved these changes
Feb 2, 2022
wxing1292
reviewed
Feb 2, 2022
wxing1292
reviewed
Feb 2, 2022
yiminc
force-pushed
the
test_migration
branch
from
1cc50e9 to
dbfa4d9
Compare
yiminc
force-pushed
the
test_migration
branch
from
dbfa4d9 to
c23ca69
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changed?
Added more tests for namespace promotion
Why?
How did you test it?
Potential risks
Is hotfix candidate?