Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update developer tools #2454

Merged
merged 1 commit into from
Feb 3, 2022
Merged

Conversation

alexshtin
Copy link
Member

@alexshtin alexshtin commented Feb 2, 2022

What changed?
Update developer tools to latest available versions. Developers may want to run make update-tools locally after this PR is merged, There is no notable changes though.

Why?
Keep tools up to date.

How did you test it?
Update and build locally.

Potential risks
No risks.

Is hotfix candidate?
No.

@alexshtin alexshtin requested a review from a team as a code owner February 2, 2022 19:39
@go install golang.org/x/tools/cmd/goimports@v0.1.5
@go install honnef.co/go/tools/cmd/staticcheck@v0.2.1
@go install golang.org/x/lint/golint@latest
@go install golang.org/x/tools/cmd/goimports@latest
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is what google recommends for goimports: https://pkg.go.dev/golang.org/x/tools/cmd/goimports#pkg-overview.

@yiminc yiminc merged commit 9454db2 into temporalio:master Feb 3, 2022
@alexshtin alexshtin deleted the feature/update-tools branch February 3, 2022 01:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants