Handle history not found error when archiving history #2465
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
yycptt
force-pushed
the
archival-non-exist
branch
from
841102b to
3ada53e
Compare
yiminc
approved these changes
Feb 4, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changed?
Skip archival if workflow history not found.
Why?
It's possible that history archiver get multiple requests for archiving the same workflow (e.g. when signal system workflow times out and retry).
Skip archival if workflow history not found. If workflow history not found, we currently return an non-retryable error immediately. It's the same as just return from the Archive method with nil error in terms of behavior since workflow won't retry the non-retryable error. As not found is an expected error, we should not emit non-retryable log/metric.
#2464
How did you test it?
Unit test
Potential risks
Is hotfix candidate?