Move search attribute validator and mapper calls to frontend service #2476
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
yiminc
reviewed
Feb 8, 2022
|
It doesn't. The design is to map alias to field name right away and use actual field name everywhere down the road. History events and mutable state, both store search attributes using actual field name. On the way out ( |
yux0
reviewed
Feb 8, 2022
| @@ -423,6 +423,8 @@ func (c *temporalImpl) startFrontend(hosts map[string][]string, startWG *sync.Wa | |||
| fx.Provide(func() authorization.JWTAudienceMapper { return nil }), | |||
| fx.Provide(func() client.FactoryProvider { return client.NewFactoryProvider() }), | |||
| fx.Provide(func() searchattribute.Mapper { return nil }), | |||
| // Comment the line above and uncomment the line bellow to test with search attributes mapper. | |||
| // fx.Provide(func() searchattribute.Mapper { return NewSearchAttributeTestMapper() }), | |||
There was a problem hiding this comment.
any reason it cannot test the sa mapper by default?
There was a problem hiding this comment.
This will require rewrite of all tests to use aliases instead of actual search attribute field names. Ideally, I would create another test suite and setup another cluster there but this requires massive integration tests refactoring.
yux0
approved these changes
Feb 9, 2022
alexshtin
added a commit
that referenced
this pull request
Feb 10, 2022
alexshtin
added a commit
that referenced
this pull request
Feb 11, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changed?
Move search attribute validator and mapper calls to frontend service.
Why?
Calling search attributes mapper from history engine cause them to be mapped twice in case if workflow is started from command (child workflow and continue as new).
How did you test it?
Existing tests.
Potential risks
No risks.
Is hotfix candidate?
Maybe.