Use throttled logger and use error type in metrics client #2477
+124
−22
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wxing1292
approved these changes
Feb 8, 2022
yiminc
reviewed
Feb 9, 2022
| case *serviceerror.ResourceExhausted: | ||
| return ErrorTypeResourceExhausted | ||
| default: | ||
| return ErrorTypeUnknown |
There was a problem hiding this comment.
How are we going to be able to use this? The idea of this error type tag with throttled logger is we can filter on the error type in logging to see what is happening.
There was a problem hiding this comment.
I think we should return fmt.Sprintf("%T", err)
yiminc
reviewed
Feb 9, 2022
Comment on lines
+620
to
+621
| c.throttledLogger.Error("history client encountered error", tag.Error(err)) | ||
| scope.Tagged(metrics.ServiceErrorTypeTag(err)).IncCounter(metrics.ClientFailures) |
There was a problem hiding this comment.
we should add field for error type to the log line that is the same as the tag on metrics so when we observer some error type from metrics, we can filter on log for that type.
Ardagan
reviewed
Feb 9, 2022
| client historyservice.HistoryServiceClient | ||
| metricsClient metrics.Client | ||
| logger log.Logger | ||
| throttledLogger log.Logger |
There was a problem hiding this comment.
might be worth moving resource.ThrottledLogger to log package and use this type instead
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changed?
Use throttled logger and use error type in metrics client
Why?
The logger and metrics may be noisy to identify issues.
How did you test it?
Added unit tests
Potential risks
Is hotfix candidate?