Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add error type for logging in clients #2480

Merged
merged 2 commits into from
Feb 9, 2022

Conversation

yux0
Copy link
Contributor

@yux0 yux0 commented Feb 9, 2022

What changed?

  1. Add error type for logging in clients.
  2. Use error type instead of predefined values

Why?
Add error type for logging in clients to filter error type in logs.

How did you test it?

Potential risks

Is hotfix candidate?

@yux0 yux0 requested a review from yiminc February 9, 2022 03:25
@yux0 yux0 requested a review from a team as a code owner February 9, 2022 03:25
common/log/tag/tags.go Show resolved Hide resolved
@yux0 yux0 merged commit 0e9f415 into temporalio:master Feb 9, 2022
@yux0 yux0 deleted the logging-error-type branch February 9, 2022 04:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants