Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changed?
tally.Timer
instead of histogram for timer metrics. The reason is that when usinghistogram.RecordDuration
, if the duration is higher than the max bucket defined, anInf
value will be added to the sum metric emitted and breaks the average calculation. When usinghistogram.RecordValue
, if value is higher than the max bucket defined, no metric will be emitted for the sum metric, and make it inaccurate. Also forRecordValue
, the value added to the sum metric is always the defined bucket boundary instead of the actual metric value.tally.Timer
implementation has none of the problems mentioned above.tally.Timer
metric, and the default reporter bucket will be used. So wired up the code to specify the default bucket for reporter, which is only used byTimer
metric.DefaultHistogramBuckets
andDefaultHistogramBoundaries
so that the code is backward compatible with older versions. Since value defined inClientConfig.PerUnitHistogramBoundaries
was not previously used, it will only be used when neitherDefaultHistogramBuckets
norDefaultHistogramBoundaries
is specified.DefaultHistogramBuckets
andDefaultHistogramBoundaries
config fields.Why?
How did you test it?
Potential risks
No risks.
Is hotfix candidate?