Update slices.SortFunc for Go 1.21 #4772
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
|
This is a different version of #4706 , made from the DataDog account's fork instead of my personal account, in an attempt to get the CLA bot to approve it. It appears this is not approved, however DataDog's open source lawyer claims that we have signed a corporate CLA with Temporal. How can I get this verified? Thanks! |
The golang.org/x/exp module was updated to use the same function signature as Go 1.21's upcoming slices.SortFunc function. This changed the return value from a bool (less than) to an int (compare to). Update Temporal to the latest version and fix the uses. For more details about this change, see the following issue and commit: - golang/go#61374 - https://cs.opensource.google/go/x/exp/+/302865e7556b4ae5de27248ce625d443ef4ad3ed
evanj
force-pushed
the
evan.jones/exp-slices-update
branch
from
f63c104
to
660a838
Compare
|
Okay I've signed the CLA: my confusion was that the CLA says "Individual Contributor License Agreement" but Datadog's open source community person told me that I should click "approve" on that. The CLA should be signed now. Thanks. |
|
This is landed as #4706 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changed?
The golang.org/x/exp module was updated to use the same function signature as Go 1.21's upcoming slices.SortFunc function. This changed the return value from a bool (less than) to an int (compare to). Update Temporal to the latest version and fix the uses.
For more details about this change, see the following issue and commit:
Why?
I am attempting to build code in a repository that imports Temporal and has updated to the latest version of this third-party library.
How did you test it?
I only ran the unit tests.
Potential risks
It is possible that I have accidentally reversed the sort order in some cases, but otherwise this should be low risk.
Is hotfix candidate?
No