Adding ListQueues in History and Admin service #5110
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| } | ||
|
|
||
| message ListQueuesResponse { | ||
| repeated string queue_names = 1; |
There was a problem hiding this comment.
Won't clients need the next page token here?
There was a problem hiding this comment.
Yes. Added the token.
| // enqueueing a task into the DLQ and then calling [getdlqtasks.Invoke] to verify that the right task is returned. | ||
| func TestInvoke(t *testing.T, manager persistence.HistoryTaskQueueManager) { | ||
| ctx := context.Background() | ||
| t.Run("HappyPath", func(t *testing.T) { |
There was a problem hiding this comment.
Could we do a paginated query on the happy path? For example, add 3 queues, query through with a page size of 2 and verify that we get all 3 once the response's next page token is empty?
There was a problem hiding this comment.
Yeah added that to this test.
prathyushpv
force-pushed
the
ppv/listqueues2
branch
from
26b39b5
to
74b495c
Compare
prathyushpv
changed the title
MichaelSnowden
approved these changes
Nov 16, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changed?
Adding ListQueues API to history service and admin service.
Why?
Operators will be using these APIs to get the list of DLQs.
A command will be added to tdbg to call this API.
How did you test it?
Unit tests with 100% coverage.
Potential risks
Is hotfix candidate?