Fix tchannel race condition #5125
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MichaelSnowden
force-pushed
the
snowden/tchannel-race
branch
from
28a18b3
to
70d8d17
Compare
tdeebswihart
approved these changes
Nov 16, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changed?
This PR updates our version of tchannel to one that contains this change: temporalio/tchannel-go#7.
Why?
This should fix a rare race condition that happens where a tchannel is used while there are still handlers being added to it.
How did you test it?
I didn't reproduce it actually, but it's a very small change, and the race condition is pretty clear to see.
Potential risks
The only other changes pulled in from this upgrade were changes to the go.mod in tchannel-go, which look pretty innocuous:
Is hotfix candidate?
No, it can wait. This only comes up super rarely.