Enable Update Workflow by default #6385
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dandavison
reviewed
Aug 8, 2024
common/dynamicconfig/constants.go
Outdated
| `FrontendEnableUpdateWorkflowExecutionAsyncAccepted enables the form of | ||
| asynchronous workflow execution update that waits on the "Accepted" | ||
| lifecycle stage. Default value is 'false'.`, | ||
| asynchronous workflow execution update that waits on the "Accepted" lifecycle stage.`, |
There was a problem hiding this comment.
Suggest not using "asynchronous" in text to mean the variant of Update that waits for Accepted. In https://docs.temporal.io/encyclopedia/workflow-message-passing#for-write-requests all Update usage is classified as synchronous. cc @drewhoskins-temporal
I think the dynamic config entry name itself is not changeable.
alexshtin
reviewed
Aug 8, 2024
| @@ -902,10 +902,8 @@ used when the first cache layer has a miss. Requires server restart for change t | |||
|
|
|||
| FrontendEnableUpdateWorkflowExecution = NewNamespaceBoolSetting( | |||
| "frontend.enableUpdateWorkflowExecution", | |||
| false, | |||
| `FrontendEnableUpdateWorkflowExecution enables UpdateWorkflowExecution API in the frontend. | |||
| The UpdateWorkflowExecution API has gone through rigorous testing efforts but this config's default is 'false' until the | |||
There was a problem hiding this comment.
rigorous testing efforts
this is very true!
alexshtin
approved these changes
Aug 8, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changed?
Enable Update Workflow (sync and async) by default.
Note that I'm leaving the flag and the code checks for now, in case we need to disable it again.
Why?
For public preview.
How did you test it?
Potential risks
Documentation
Is hotfix candidate?