Fix UI escaping special symbols #118
Conversation
| @@ -139,3 +139,5 @@ require ( | |||
| gopkg.in/validator.v2 v2.0.1 // indirect | |||
| gopkg.in/yaml.v3 v3.0.1 // indirect | |||
| ) | |||
|
|
|||
| replace github.com/grpc-ecosystem/grpc-gateway => github.com/temporalio/grpc-gateway v1.17.0 | |||
There was a problem hiding this comment.
Can you give me a brief update of what we customize in our custom fork of grpc-gateway and the potential status of upstreaming our changes? Is it solely due to temporalio/grpc-gateway#1? I see they're on a separate major version by now.
There was a problem hiding this comment.
We may also need to make a note about this override for library users who are depending on Temporalite through go mod.
There was a problem hiding this comment.
the initial issue came from sveltejs/kit#3069
grpc-gateway v2 introduced an option WithUnescapingMode that would allow to address the escaping properly, however this was not moved into v1. See grpc-ecosystem/grpc-gateway#2629 for context and why we had to fork
There was a problem hiding this comment.
also considered upgrading to grpc-gateway v2, asked the server team if we could move to protobuf-apiv2. In short such upgrade didn't get into our timeline yet because of many moving pieces
There was a problem hiding this comment.
added a readme comment
There was a problem hiding this comment.
That's unfortunate but understandable.
There was a problem hiding this comment.
@feedmeapples is there an existing issue for migrating to the v2 protobuf libraries we can link here?
feedmeapples
force-pushed
the
fix-escaping
branch
from
71294bd
to
dce24d7
Compare
feedmeapples
force-pushed
the
fix-escaping
branch
from
dce24d7
to
9312e58
Compare
What changed?
Fixes escaping of special URL symbols
Why?
Resolves #117
How did you test it?
Verified with a workflow id that has spaces, /, %, /, \ etc https://github.com/minimaxir/big-list-of-naughty-strings
Potential risks
Is hotfix candidate?