This repository has been archived by the owner on Apr 3, 2024. It is now read-only.
Test creating default db directory #144
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jlegrone
force-pushed
the
jlegrone/test-startup-create-dir
branch
from
3f71021 to
62ba25f
Compare
cretz
approved these changes
Sep 29, 2022
jlegrone
force-pushed
the
jlegrone/test-startup-create-dir
branch
from
625eca5 to
8ce9f21
Compare
jlegrone
force-pushed
the
jlegrone/test-startup-create-dir
branch
from
8ce9f21 to
7ee3016
Compare
cretz
reviewed
Sep 29, 2022
cretz
approved these changes
Sep 29, 2022
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changed?
This PR adds test cases for creating the default data directory when it doesn't already exist, returning an error when a custom db path is configured in a missing directory, and starting the server with a custom db path in an existing directory.
I've also removed panic logs in integration tests and increased timeouts in an attempt to decrease test flakiness. This was done with a new
--log-format noopflag value.Why?
This is basic behavior that I believe should be validated with an integration test. The test case for starting Temporal server with a default db path will also catch any breaking change that updates the default path.
How did you test it?
CI
Potential risks
I noticed a whole host of race conditions in the integration tests during development. Most have been quashed, however we should be on the lookout for new flakiness introduced by these test cases.
Is hotfix candidate?
No