Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

API Keys: Do not allow importing #202

Merged
merged 3 commits into from
Dec 3, 2024
Merged

API Keys: Do not allow importing #202

merged 3 commits into from
Dec 3, 2024

Conversation

briankassouf
Copy link
Contributor

@briankassouf briankassouf commented Dec 2, 2024

What was changed

This PR disables the ability to import API Keys from the Cloud Ops API into Terraform State.

Why?

The provider currently supports importing of API Keys. However the Cloud Ops API will only return the API key token on initial creation and so any attempt at importing will produce an incomplete state and an invalid plan:

Terraform used the selected providers to generate the following execution plan. Resource actions are indicated with the following symbols:
  ~ update in-place

Terraform will perform the following actions:

  # temporalcloud_apikey.global_apikey will be updated in-place
  ~ resource "temporalcloud_apikey" "global_apikey" {
        id           = "..."
      + token        = (sensitive value)
        # (5 unchanged attributes hidden)
    }

Plan: 0 to add, 1 to change, 0 to destroy.

Checklist

  1. Closes

  2. How was this tested:

  1. Any docs updates needed?

Copy link
Collaborator

@jlacefie jlacefie left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

TY

@briankassouf briankassouf merged commit 7ccb9e8 into main Dec 3, 2024
5 checks passed
@briankassouf briankassouf deleted the bk/api-key-import branch December 3, 2024 17:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants