New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

updates to CONTRIBUTING for Acceptance Test guidance #203

Merged

briankassouf merged 2 commits into main from jlacefie/contguid

Dec 3, 2024

Collaborator

jlacefie commented Dec 3, 2024

What was changed

Added language to the CONTRIBUTING.MD guide to ensure users are aware that:

we recommend they run Acceptance Tests locally before submitting a PR
local ATs create real resources
due to security reasons, Temporal's automated Acceptance Tests will not run on non Temporal submitted PRs. Temporal will run these tests locally and possible fork their PR and merge the fork.

Closes [Feature Request] Configure Terraform Tests to accept PRs from forks #131


          updates to CONTRIBUTING for Acceptance Test guidance

6ab0413

jlacefie requested a review from a team as a code owner

December 3, 2024 16:42

briankassouf approved these changes

View reviewed changes

briankassouf added this to the V1.0 | GA - Community Friendly Provider milestone


          Merge branch 'main' into jlacefie/contguid

9f53bd5

briankassouf enabled auto-merge (squash)

December 3, 2024 18:24

briankassouf merged commit 15e3979 into main

5 checks passed

briankassouf deleted the jlacefie/contguid branch

December 3, 2024 18:26

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet