Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: panic due to negative coin amount when remaining is negative #80

Merged
merged 9 commits into from
Feb 5, 2022

Conversation

jaybxyz
Copy link
Contributor

@jaybxyz jaybxyz commented Feb 4, 2022

Description

closes: #78 and #79

Tasks

  • Fix to use IsLT() before substituting remaining coin from receive coin
  • Add test case to verify the fixed logic
  • Update spm dependencies
  • Bump Cosmos SDK v0.44.0 to v0.44.5

Before we can merge this PR, please make sure that all the following items have been
checked off. If any of the checklist items are not applicable, please leave them but
write a little note why.

  • Appropriate labels applied
  • Targeted PR against correct branch
  • Linked to Github issue with discussion and accepted design OR link to spec that describes this work.
  • Code follows the module structure standards.
  • Wrote unit and integration
  • Updated relevant documentation (docs/) or specification (x/<module>/spec/)
  • Added relevant godoc comments.
  • Re-reviewed Files changed in the Github PR explorer
  • Review Codecov Report in the comment section below once CI passes

@jaybxyz jaybxyz self-assigned this Feb 4, 2022
@jaybxyz
Copy link
Contributor Author

jaybxyz commented Feb 4, 2022

This codecov issue is strange

[2022-02-04T09:28:50.285Z] ['info'] 
     _____          _
    / ____|        | |
   | |     ___   __| | ___  ___ _____   __
   | |    / _ \ / _` |/ _ \/ __/ _ \ \ / /
   | |___| (_) | (_| |  __/ (_| (_) \ V /
    \_____\___/ \__,_|\___|\___\___/ \_/

  Codecov report uploader 0.1.[16](https://github.com/tendermint/fundraising/runs/5064397404?check_suite_focus=true#step:6:16)
[[20](https://github.com/tendermint/fundraising/runs/5064397404?check_suite_focus=true#step:6:20)[22](https://github.com/tendermint/fundraising/runs/5064397404?check_suite_focus=true#step:6:22)-02-04T09:28:50.291Z] ['info'] => Project root located at: /home/runner/work/fundraising/fundraising
[2022-02-04T09:28:50.295Z] ['info'] -> No token specified or token is empty
[2022-02-04T09:28:50.295Z] ['verbose'] Start of network processing...
[2022-02-04T09:28:50.295Z] ['verbose'] Searching for files in /home/runner/work/fundraising/fundraising
[2022-02-04T09:28:50.300Z] ['info'] Searching for coverage files...
[2022-02-04T09:28:50.349Z] ['info'] Warning: Some files located via search were excluded from upload.
[2022-02-04T09:28:50.349Z] ['info'] If Codecov did not locate your files, please review https://docs.codecov.com/docs/supported-report-formats
[2022-02-04T09:28:50.349Z] ['error'] There was an error running the uploader: No coverage files located, please try use `-f`, or change the project root with `-R`
[2022-02-04T09:28:50.350Z] ['verbose'] The error stack is: Error: No coverage files located, please try use `-f`, or change the project root with `-R`
    at main (/snapshot/repo/dist/src/index.js)
    at processTicksAndRejections (node:internal/process/task_queues:96:5)
[2022-02-04T09:28:50.350Z] ['verbose'] End of uploader: 67 milliseconds
Error: Codecov: Failed to properly upload: The process '/home/runner/work/_actions/codecov/codecov-action/v2/dist/codecov' failed with exit code [25](https://github.com/tendermint/fundraising/runs/5064397404?check_suite_focus=true#step:6:25)5

@jaybxyz
Copy link
Contributor Author

jaybxyz commented Feb 4, 2022

@jaybxyz
Copy link
Contributor Author

jaybxyz commented Feb 4, 2022

Resolved the above issue by change the coverage file extension to xml.

@jaybxyz jaybxyz marked this pull request as ready for review February 4, 2022 14:27
@jaybxyz jaybxyz merged commit 52c1c9a into tendermint:main Feb 5, 2022
This pull request was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

fix: negative coin amount when remaining is negative coin amount
1 participant