Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update spec doc #2

Merged
merged 9 commits into from
Oct 6, 2020
Merged

Update spec doc #2

merged 9 commits into from
Oct 6, 2020

Commits on Oct 6, 2020

  1. updated message section 

    - Token -> Coin
- Chose right naming between Coins and Coin
- Add validity check description
- Remove unnecessary items in structs
    @Hyung-bharvest
    Hyung-bharvest authored Oct 6, 2020
    Configuration menu
    Copy the full SHA
    f2978a8 View commit details
    Browse the repository at this point in the history

  2. token -> coin

    @Hyung-bharvest
    Hyung-bharvest authored Oct 6, 2020
    Configuration menu
    Copy the full SHA
    90d2772 View commit details
    Browse the repository at this point in the history

  3. update states section 

    - token -> coin
- remove SwapFeeRate, PoolFeeRate, BatchSize, LastBatchIndex in LiquidityPool struct
    @Hyung-bharvest
    Hyung-bharvest authored Oct 6, 2020
    Configuration menu
    Copy the full SHA
    28416b4 View commit details
    Browse the repository at this point in the history

  4. update state transition section 

    - token -> coin
    @Hyung-bharvest
    Hyung-bharvest authored Oct 6, 2020
    Configuration menu
    Copy the full SHA
    0845caf View commit details
    Browse the repository at this point in the history

  5. update end block section 

    - token -> coin
- delete CreateNewLiquidityPool process from end-block
- delete description about LastBatchIndex
- BatchSize is global parameter, not for each LiquidityPool
    @Hyung-bharvest
    Hyung-bharvest authored Oct 6, 2020
    Configuration menu
    Copy the full SHA
    dbdce52 View commit details
    Browse the repository at this point in the history

  6. update event section 

    - token -> coin
- coins vs coin
- remove unnecessary items
    @Hyung-bharvest
    Hyung-bharvest authored Oct 6, 2020
    Configuration menu
    Copy the full SHA
    339ef3c View commit details
    Browse the repository at this point in the history

  7. update params section 

    - remove swap price function in LiquidityPoolTypes
- change num_of_reserve_tokens to range_of_reserve_coin_num in LiquidityPoolTypes
- add name to LiquidityPoolTypes
- add LiquidityPoolCreationFee and UnitBatchSize
    @Hyung-bharvest
    Hyung-bharvest authored Oct 6, 2020
    Configuration menu
    Copy the full SHA
    0d25e2c View commit details
    Browse the repository at this point in the history

  8. update readme 

    token -> coin
    @Hyung-bharvest
    Hyung-bharvest authored Oct 6, 2020
    Configuration menu
    Copy the full SHA
    a7ea1b8 View commit details
    Browse the repository at this point in the history

  9. Add Min, MaxReserveCoinNum, Fix indent

    @nodebreaker0-0 @dongsam
    nodebreaker0-0 authored and dongsam committed Oct 6, 2020
    Configuration menu
    Copy the full SHA
    93b43df View commit details
    Browse the repository at this point in the history