Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

release liquidity v1.4.1 #459

Merged
merged 8 commits into from
Oct 25, 2021
Merged

release liquidity v1.4.1 #459

merged 8 commits into from
Oct 25, 2021

Conversation

dongsam
Copy link
Contributor

@dongsam dongsam commented Oct 25, 2021

Description

closes: #447


Before we can merge this PR, please make sure that all the following items have been
checked off. If any of the checklist items are not applicable, please leave them but
write a little note why.

  • Targeted PR against correct branch (see CONTRIBUTING.md)
  • Linked to Github issue with discussion and accepted design OR link to spec that describes this work.
  • Code follows the module structure standards.
  • Wrote unit and integration tests
  • Updated relevant documentation (docs/) or specification (x/<module>/spec/)
  • Added relevant godoc comments.
  • Added a relevant changelog entry to the Unreleased section in CHANGELOG.md
  • Re-reviewed Files changed in the Github PR explorer
  • Review Codecov Report in the comment section below once CI passes

jaybxyz and others added 8 commits October 6, 2021 16:34
…checker

feat: add markdown links checker workflow
feat: bump Cosmos SDK from v0.44.0 to v0.44.1
* fix: wip poc for reproduce and fix poolcoin truncation

* fix: simplify calculation logic and add more tests

WIP

* fix: use equality check in MintingPoolCoinsInvariant

* test: fix expected value

due to the change in deposit logic, expected value in test
also changed

* test: add test for MintingPoolCoinsInvariant

* fix: update deposit truncation logic and simulation ordering

* docs: update changelog and readme

* fix: revert MulTruncate to Mul on Deposit

Co-authored-by: Hanjun Kim <hallazzang@gmail.com>
* test: add testcase for cover small withdrawal case

* test: add test case for CreatePool

* fix: refactor and optimize depleted pool validation

* feat: add overflow checking logic

* chore: add testcase and remove comments

* test: add test code for big deposit

* fix: apply PR suggestions

* fix: add overflow checking logic and test cases

Co-authored-by: Hanjun Kim <hallazzang@gmail.com>
Co-authored-by: typark391 <86215716+typark391@users.noreply.github.com>
@codecov
Copy link

codecov bot commented Oct 25, 2021

Codecov Report

Merging #459 (e0def69) into master (aa1af26) will increase coverage by 0.39%.
The diff coverage is 93.33%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #459      +/-   ##
==========================================
+ Coverage   85.10%   85.49%   +0.39%     
==========================================
  Files          23       23              
  Lines        2618     2634      +16     
==========================================
+ Hits         2228     2252      +24     
+ Misses        226      221       -5     
+ Partials      164      161       -3     
Impacted Files Coverage Δ
x/liquidity/keeper/swap.go 62.92% <25.00%> (-1.45%) ⬇️
x/liquidity/keeper/liquidity_pool.go 84.62% <95.12%> (+0.97%) ⬆️
x/liquidity/keeper/batch.go 89.15% <100.00%> (+0.33%) ⬆️
x/liquidity/keeper/invariants.go 66.31% <100.00%> (+1.79%) ⬆️
x/liquidity/types/swap.go 79.22% <100.00%> (+0.11%) ⬆️
x/liquidity/types/utils.go 89.06% <100.00%> (+3.64%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update aa1af26...e0def69. Read the comment docs.

@dongsam dongsam merged commit 6fad886 into master Oct 25, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants