Skip to content
This repository has been archived by the owner on Feb 23, 2022. It is now read-only.

proto: merge the proposer-based timestamps parameters #393

Merged
merged 9 commits into from
Feb 2, 2022

Conversation

williambanfield
Copy link
Contributor

These parameters were previously merged into the proposer-based timestamps long-lived branch.
This pull request merges these parameters into the main branch and updates the proto files to include documentation.

Copy link
Contributor

@creachadair creachadair left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Apart from one minor nit, LGTM.

// see the specification of proposer-based timestamps:
// https://github.com/tendermint/spec/tree/master/spec/consensus/proposer-based-timestamp
message SynchronyParams {
// message_delay bounds how long a proposal message may take to reach all validators on a newtork
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The indentation here appears a little wonky. Tabs?

@cmwaters
Copy link
Contributor

cmwaters commented Feb 1, 2022

Is this the only place we mention ConsensusParams in the spec? Are there any other places that may need updating?

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants