This repository has been archived by the owner on Feb 23, 2022. It is now read-only.
add basic description of ABCI Commit.ResponseHeight #85
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
erikgrinaker
requested review from
josef-widder,
konnov and
milosevic
as code owners
tac0turtle
approved these changes
Apr 9, 2020
Yes, it should, but all the other height parameters in ABCI use int64 so I kept it for consistency. At some point we should move them all to uint64. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Documentation for block pruning, once it's merged: tendermint/tendermint#4588.
Minimum documentation, for now - we probably shouldn't encourage using this feature too much until we release state sync.