testing: tests were not being run on all dbs #42
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- added tsting for all dbs - this should of been caught earlier - will add this to ci as well Signed-off-by: Marko Baricevic <marbar3778@yahoo.com>
|
prior to the interface errors refactor I believe rocksdb was not abiding by the interface. This will help avoid all of this |
|
this is blocked on getting a docker image produced. have a PR here: tendermint/images#37 |
|
add codecov in with this PR since ci is being touched, it would be useful |
tac0turtle
commented
Jan 17, 2020
makefile
Outdated
|
|
||
| test-all: | ||
| @echo "--> Running go test" | ||
| @go test -p 1 $(PACKAGES) -tags cleveldb,boltdb |
There was a problem hiding this comment.
Suggested change
| @go test -p 1 $(PACKAGES) -tags cleveldb,boltdb | |
| @go test -p 1 $(PACKAGES) -tags cleveldb,boltdb,rocksdb |
add back rocksdb
|
What is remaining here? |
|
just need to pass the correct path to rocksdb when running the tests |
|
Do you mind if I pick this up? I'm seeing some bugs in the other backends that would be caught by the common test suite. |
|
yea for sure!! thank you |
|
Closing in favor of #64, since most changes here have been ported to |
faddat
pushed a commit
to notional-labs/tm-db
that referenced
this pull request
May 8, 2022
faddat
pushed a commit
to faddat/tm-db
that referenced
this pull request
Feb 21, 2024
* use grocksdb to support latest version of rocksdb also add API `NewRocksDBWithRawDB` to support read-only open mode and customize options * update rocksdb version for ci testing * build(deps): bump docker/setup-buildx-action from 2.4.1 to 2.5.0 (tendermint#47) Bumps [docker/setup-buildx-action](https://github.com/docker/setup-buildx-action) from 2.4.1 to 2.5.0. - [Release notes](https://github.com/docker/setup-buildx-action/releases) - [Commits](docker/setup-buildx-action@v2.4.1...v2.5.0) --- updated-dependencies: - dependency-name: docker/setup-buildx-action dependency-type: direct:production update-type: version-update:semver-minor ... Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> * fix ci test * grocksdb v1.7.16 * rocksdb v7.10.2 * changelog * fix changelog --------- Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: Thane Thomson <connect@thanethomson.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Marko Baricevic marbar3778@yahoo.com