iterator: improve and document error handling #97
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Merged
melekes
approved these changes
May 16, 2020
erikgrinaker
force-pushed
the
erik/iterator-error
branch
from
114f5a4
to
a472933
Compare
nddeluca
pushed a commit
to Kava-Labs/tm-db
that referenced
this pull request
Jan 8, 2024
* build(deps): bump github.com/linxGnu/grocksdb from 1.7.16 to 1.8.6 Bumps [github.com/linxGnu/grocksdb](https://github.com/linxGnu/grocksdb) from 1.7.16 to 1.8.6. - [Release notes](https://github.com/linxGnu/grocksdb/releases) - [Commits](linxGnu/grocksdb@v1.7.16...v1.8.6) --- updated-dependencies: - dependency-name: github.com/linxGnu/grocksdb dependency-type: direct:production update-type: version-update:semver-minor ... Signed-off-by: dependabot[bot] <support@github.com> * Use OS-provided cleveldb instead of manually building Signed-off-by: Thane Thomson <connect@thanethomson.com> * Use latest versio of RocksDB Signed-off-by: Thane Thomson <connect@thanethomson.com> * Add changelog entry Signed-off-by: Thane Thomson <connect@thanethomson.com> --------- Signed-off-by: dependabot[bot] <support@github.com> Signed-off-by: Thane Thomson <connect@thanethomson.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The iterator pattern we're using typically panics on use of invalid iterators (including our backends). I've kept this pattern, but tried to reduce the amount of panics and return via
Error()instead, and also madeClose()panic.Our iterator examples did not include checking
Error(), so this is likely to break many applications that today rely on iterator panics for error handling (e.g. IAVL, see cosmos/iavl#247).Branched off of #96.