Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

reject nil/empty keys and nil values #99

Merged
merged 7 commits into from
May 19, 2020
Merged

reject nil/empty keys and nil values #99

merged 7 commits into from
May 19, 2020

Conversation

erikgrinaker
Copy link
Contributor

Fixes #2.

@erikgrinaker erikgrinaker added T:breaking Type: Breaking S:automerge Status: Auto merge a pull request labels May 18, 2020
@erikgrinaker erikgrinaker requested a review from melekes May 18, 2020 15:16
@erikgrinaker erikgrinaker requested a review from tessr as a code owner May 18, 2020 15:16
@erikgrinaker erikgrinaker self-assigned this May 18, 2020
@erikgrinaker erikgrinaker removed the S:automerge Status: Auto merge a pull request label May 18, 2020
@erikgrinaker erikgrinaker merged commit 7b7076b into master May 19, 2020
@erikgrinaker erikgrinaker deleted the erik/reject-empty-keys branch May 19, 2020 10:22
@erikgrinaker erikgrinaker mentioned this pull request May 20, 2020
Closed
melekes
melekes reviewed May 25, 2020
View reviewed changes
Copy link
Contributor

@melekes melekes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

nddeluca pushed a commit to Kava-Labs/tm-db that referenced this pull request Jan 8, 2024
@thanethomson @andynog
Release v0.9.0 (tendermint#99)
bd63900 
* Prepare changelog

Signed-off-by: Thane Thomson <connect@thanethomson.com>

* Fix date in changelog summary

Signed-off-by: Thane Thomson <connect@thanethomson.com>

* Update CHANGELOG.md

Co-authored-by: Andy Nogueira <me@andynogueira.dev>

---------

Signed-off-by: Thane Thomson <connect@thanethomson.com>
Co-authored-by: Andy Nogueira <me@andynogueira.dev>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@melekes melekes melekes left review comments

@tessr tessr tessr approved these changes

Assignees

@erikgrinaker erikgrinaker

Labels
T:breaking Type: Breaking
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

libs/db: disallow empty keys
3 participants
@erikgrinaker @tessr @melekes