This repository has been archived by the owner on Jun 3, 2020. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 43
Off By One Error when Chain Height is 1 #369
Comments
https://github.com/tendermint/kms/blob/b361d15/src/session.rs#L252 If the issue is the |
Sounds like a better idea to not write to disk until it signs something if it does not find an existing state file. |
tarcieri
added a commit
that referenced
this issue
Dec 12, 2019
Use an initial height of 0 in default chain state (fixes #369)
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Versions Tested: Current Master (b361d15) ,
Commits that must be included:
Description:
tmkms creates a blank file (priv_valdiator_state.json) when no such file is present.
Contents:
{"height":"1","round":"0","step":0,"block_id": null}
When a request for SignProposal is sent to tmkms ( It has a step of 0 ), tmkms checks the current state file for
step
and finds 0, which is the int forSignProposal
This gives the following error:
Fix:
It should create a blank file with step - 1
Contents:
{"height":"1","round":"0","step":-1,"block_id": null}
The text was updated successfully, but these errors were encountered: