Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(context): Support unix context and daemonless #1062

Merged
merged 5 commits into from
Oct 21, 2022

Conversation

gaocegege
Copy link
Member

@gaocegege gaocegege commented Oct 20, 2022

Fix #1056

This PR adds two new image tensorchord/envd-from-scratch built by goreleaser, and tensorchord/envd built by the build.sh.

Users can use tensorchord:envd to run build daemonlessly:

docker run \                                                        
    -it \                                                                                       
    --rm \                                                                                      
    --security-opt seccomp=unconfined \                                                         
    --security-opt apparmor=unconfined \                                                        
    -e BUILDKITD_FLAGS=--oci-worker-no-process-sandbox \                                        
    --entrypoint /envd-daemonless.sh \                                                          
    -v /home/gaocegege/code/go/src/github.com/tensorchord/envd/examples/python-basic:/tmp/work t
ensorchord/envd:daemonless-rootless --debug build -p /tmp/work --output type=image,name=test   

VoVAllen
VoVAllen previously approved these changes Oct 20, 2022
Copy link
Member

@VoVAllen VoVAllen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. What's the advantage of daemonless?

@muniu-bot muniu-bot bot added the approved label Oct 20, 2022
@gaocegege
Copy link
Member Author

LGTM. What's the advantage of daemonless?

As @Xiaoaier-Z-L said, there is no need to launch a buildkitd deployment on Kubernetes. We can just create a job to build envd image.

Signed-off-by: Ce Gao <cegao@tensorchord.ai>
Signed-off-by: Ce Gao <cegao@tensorchord.ai>
Signed-off-by: Ce Gao <cegao@tensorchord.ai>
Signed-off-by: Ce Gao <cegao@tensorchord.ai>
Signed-off-by: Ce Gao <cegao@tensorchord.ai>
@gaocegege
Copy link
Member Author

Comments addressed, PTAL.

Copy link
Member

@kemingy kemingy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@muniu-bot muniu-bot bot added the lgtm label Oct 21, 2022
@gaocegege gaocegege merged commit 51b00fb into tensorchord:main Oct 21, 2022
@gaocegege gaocegege deleted the unix branch October 21, 2022 01:55
@muniu-bot
Copy link

muniu-bot bot commented Oct 21, 2022

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: gaocegege, kemingy

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
No open projects
Archived in project
Development

Successfully merging this pull request may close these issues.

feat(CLI): daemonless envd build
3 participants