feat: produce ABI-agnostic wheels for python #1324
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Frost Ming <mianghong@gmail.com>
frostming
requested review from
VoVAllen,
kemingy and
gaocegege
as code owners
Signed-off-by: Frost Ming <mianghong@gmail.com>
VoVAllen
reviewed
Dec 20, 2022
Signed-off-by: Frost Ming <mianghong@gmail.com>
frostming
changed the title
frostming
changed the title
VoVAllen
reviewed
Dec 20, 2022
VoVAllen
reviewed
Dec 20, 2022
|
Thanks a lot! We have reached the storage limit of pypi several times, and this could greatly help reduce our storage usage. |
cutecutecat
reviewed
Dec 20, 2022
| @@ -110,5 +119,9 @@ def get_version(): | |||
| ext_modules=[ | |||
| EnvdExtension(name="envd", sources=["cmd/*"]), | |||
There was a problem hiding this comment.
The example provides two arguments define_macros=[("Py_LIMITED_API", "0x03060000")] and py_limited_api=True, whether we need to overwrite the init of EnvdExtension to include them?
https://setuptools.pypa.io/en/latest/userguide/ext_modules.html#setuptools.Extension
There was a problem hiding this comment.
i don't think so, there is no python api involved
There was a problem hiding this comment.
I don't think so. The original example is for the abi3-compatible package. For envd, we don't rely on any python abi or version
Co-authored-by: Jinjing Zhou <VoVAllen@users.noreply.github.com> Signed-off-by: Frost Ming <mianghong@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Frost Ming mianghong@gmail.com
The approach is taken from cibuildwheel Tips and Tricks, also quote:
This will reduce the number of wheels to upload to PyPI