Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ci: Auto-approve and merge dependabot PRs #315

Merged
merged 3 commits into from
Jun 14, 2022
Merged

ci: Auto-approve and merge dependabot PRs #315

merged 3 commits into from
Jun 14, 2022

Conversation

terrytangyuan
Copy link
Member

Signed-off-by: terrytangyuan terrytangyuan@gmail.com

Signed-off-by: terrytangyuan <terrytangyuan@gmail.com>
@terrytangyuan terrytangyuan requested a review from gaocegege June 13, 2022 14:55
@terrytangyuan
Copy link
Member Author

terrytangyuan commented Jun 13, 2022

This will auto-merge dependabot PRs (when CI builds pass) but one issue is that CI will pass anyway if there's no review requested.

Should we remove review_requested from ci.yml? I remember it's only used to save some build time on GA. We should have enough build time now since the project is open sourced.

Signed-off-by: terrytangyuan <terrytangyuan@gmail.com>
@gaocegege
Copy link
Member

Should we remove review_requested from ci.yml? I remember it's only used to save some build time on GA. We should have enough build time now since the project is open sourced.

Sure, we can remove it.

@gaocegege gaocegege merged commit 75eda00 into main Jun 14, 2022
@gaocegege gaocegege deleted the auto-approve branch June 14, 2022 01:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
No open projects
Archived in project
Development

Successfully merging this pull request may close these issues.

2 participants