Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: pypi sdist #318

Merged
merged 1 commit into from
Jun 14, 2022
Merged

fix: pypi sdist #318

merged 1 commit into from
Jun 14, 2022

Conversation

kemingy
Copy link
Member

@kemingy kemingy commented Jun 13, 2022

Signed-off-by: Keming kemingy94@gmail.com

@gaocegege gaocegege requested a review from VoVAllen June 14, 2022 02:08
@gaocegege
Copy link
Member

        - name: Docker Login
        uses: docker/login-action@v1
        with:
          registry: ghcr.io
          username: ${{ github.repository_owner }}
          password: ${{ secrets.CR_PAT }}

We need to update it, I will do it.

@gaocegege
Copy link
Member

Please rebase and give it another try.

Signed-off-by: Keming <kemingy94@gmail.com>
@kemingy
Copy link
Member Author

kemingy commented Jun 14, 2022

Please rebase and give it another try.

Fixed. @VoVAllen please take a look.

Copy link
Member

@VoVAllen VoVAllen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks!

@kemingy
Copy link
Member Author

kemingy commented Jun 14, 2022

Will the bot automatically merge the approved PR? @gaocegege I don't have the permission.

@gaocegege gaocegege merged commit 35ef36d into tensorchord:main Jun 14, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
No open projects
Archived in project
Development

Successfully merging this pull request may close these issues.

3 participants