Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bootstrap gets error if the envd_buildkitd was stopped before #417

Merged
merged 3 commits into from
Jun 17, 2022
Merged

Bootstrap gets error if the envd_buildkitd was stopped before #417

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
a1acac2
Bootstrap gets error if the envd_buildkitd was stopped before
pingsutw Jun 17, 2022
1869485
lint
pingsutw Jun 17, 2022
88562b0
Add warning
pingsutw Jun 17, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 6 additions & 0 deletions pkg/buildkitd/buildkitd.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -112,6 +112,12 @@ func (c *generalClient) maybeStart(ctx context.Context,
return "", err
}
}
running, _ := dockerClient.IsRunning(ctx, c.containerName)
if created && !running {
c.logger.Warnf("please remove or restart the container %s", c.containerName)
return "", errors.Errorf("container %s is stopped", c.containerName)
}

c.logger.Debugf("container is running, check if it's ready at %s...", c.BuildkitdAddr())

if err := c.waitUntilConnected(ctx, connectingTimeout); err != nil {
Expand Down