-
Notifications
You must be signed in to change notification settings - Fork 156
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: add runtime graph to image label #815
feat: add runtime graph to image label #815
Conversation
f5bf329
to
f75ebc0
Compare
docs/proposals/20220826-image-runtime-redistributed-metadata.md
Outdated
Show resolved
Hide resolved
1ae12fe
to
e2f0861
Compare
Signed-off-by: nullday <aseaday@hotmail.com>
Signed-off-by: nullday <aseaday@hotmail.com>
Signed-off-by: nullday <aseaday@hotmail.com>
Signed-off-by: nullday <aseaday@hotmail.com>
Signed-off-by: nullday <aseaday@hotmail.com>
Signed-off-by: nullday <aseaday@hotmail.com>
d8e2b17
to
75c5e60
Compare
Signed-off-by: nullday <aseaday@hotmail.com>
Signed-off-by: nullday <aseaday@hotmail.com>
Signed-off-by: nullday <aseaday@hotmail.com>
The only concern I have is whether there's any limit on the tag value length. However, I searched around and didn't find any explicitly stated limit, on docker hub/harbor/AWS ECR. I'm fine with this PR but probably we need some manual tests to see whether there's any potential compatibility issue. (i.e. for AWS ECR, the image tag may also be converted to AWS tag, which has a limit of 256 characters) |
/lgtm |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: aseaday, gaocegege The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
I also don't find it in OCI spec but I don't know aws ecr has this limit. Let me give a cut off if length is over 256. |
I do not think we should support such case since it is not the requirements of OCI spec. |
I think we can merge this PR now and open new issue to track runtime label. I am going to work on other issues now. @gaocegege |
#789
Signed-off-by: nullday aseaday@hotmail.com