Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add runtime graph to image label #815

Merged
merged 10 commits into from
Sep 6, 2022

Conversation

aseaday
Copy link
Member

@aseaday aseaday commented Aug 26, 2022

#789
Signed-off-by: nullday aseaday@hotmail.com

@aseaday aseaday changed the title WIP feat: add proposal for runtime graph image label WIP feat: add runtime graph to image label Sep 2, 2022
@aseaday aseaday changed the title WIP feat: add runtime graph to image label feat: add runtime graph to image label Sep 2, 2022
pkg/lang/ir/util.go Outdated Show resolved Hide resolved
pkg/lang/ir/util.go Outdated Show resolved Hide resolved
go.mod Outdated Show resolved Hide resolved
Signed-off-by: nullday <aseaday@hotmail.com>
Signed-off-by: nullday <aseaday@hotmail.com>
Signed-off-by: nullday <aseaday@hotmail.com>
Signed-off-by: nullday <aseaday@hotmail.com>
Signed-off-by: nullday <aseaday@hotmail.com>
Signed-off-by: nullday <aseaday@hotmail.com>
Signed-off-by: nullday <aseaday@hotmail.com>
Signed-off-by: nullday <aseaday@hotmail.com>
Signed-off-by: nullday <aseaday@hotmail.com>
kemingy
kemingy previously approved these changes Sep 6, 2022
go.mod Outdated Show resolved Hide resolved
Signed-off-by: nullday <aseaday@hotmail.com>
@VoVAllen
Copy link
Member

VoVAllen commented Sep 6, 2022

The only concern I have is whether there's any limit on the tag value length. However, I searched around and didn't find any explicitly stated limit, on docker hub/harbor/AWS ECR. I'm fine with this PR but probably we need some manual tests to see whether there's any potential compatibility issue. (i.e. for AWS ECR, the image tag may also be converted to AWS tag, which has a limit of 256 characters)

@VoVAllen
Copy link
Member

VoVAllen commented Sep 6, 2022

/lgtm

@muniu-bot muniu-bot bot added the lgtm label Sep 6, 2022
@muniu-bot
Copy link

muniu-bot bot commented Sep 6, 2022

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: aseaday, gaocegege

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@aseaday
Copy link
Member Author

aseaday commented Sep 6, 2022

The only concern I have is whether there's any limit on the tag value length. However, I searched around and didn't find any explicitly stated limit, on docker hub/harbor/AWS ECR. I'm fine with this PR but probably we need some manual tests to see whether there's any potential compatibility issue. (i.e. for AWS ECR, the image tag may also be converted to AWS tag, which has a limit of 256 characters)

I also don't find it in OCI spec but I don't know aws ecr has this limit. Let me give a cut off if length is over 256.

@gaocegege
Copy link
Member

The only concern I have is whether there's any limit on the tag value length. However, I searched around and didn't find any explicitly stated limit, on docker hub/harbor/AWS ECR. I'm fine with this PR but probably we need some manual tests to see whether there's any potential compatibility issue. (i.e. for AWS ECR, the image tag may also be converted to AWS tag, which has a limit of 256 characters)

I also don't find it in OCI spec but I don't know aws ecr has this limit. Let me give a cut off if length is over 256.

I do not think we should support such case since it is not the requirements of OCI spec.

@aseaday
Copy link
Member Author

aseaday commented Sep 6, 2022

The only concern I have is whether there's any limit on the tag value length. However, I searched around and didn't find any explicitly stated limit, on docker hub/harbor/AWS ECR. I'm fine with this PR but probably we need some manual tests to see whether there's any potential compatibility issue. (i.e. for AWS ECR, the image tag may also be converted to AWS tag, which has a limit of 256 characters)

I also don't find it in OCI spec but I don't know aws ecr has this limit. Let me give a cut off if length is over 256.

I do not think we should support such case since it is not the requirements of OCI spec.

I think we can merge this PR now and open new issue to track runtime label. I am going to work on other issues now. @gaocegege

@gaocegege gaocegege merged commit 8056fda into tensorchord:main Sep 6, 2022
@aseaday aseaday deleted the feat/add_redistributed_tag branch November 1, 2022 11:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
No open projects
Archived in project
Development

Successfully merging this pull request may close these issues.

5 participants