add embedding support in main.py #22
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kemingy
requested changes
May 24, 2023
gaocegege
reviewed
May 24, 2023
Signed-off-by: Teddy Xinyuan Chen <45612704+tddschn@users.noreply.github.com>
Signed-off-by: Teddy Xinyuan Chen <45612704+tddschn@users.noreply.github.com>
Signed-off-by: Teddy Xinyuan Chen <45612704+tddschn@users.noreply.github.com>
gaocegege
reviewed
May 24, 2023
Signed-off-by: Teddy Xinyuan Chen <45612704+tddschn@users.noreply.github.com>
Signed-off-by: Teddy Xinyuan Chen <45612704+tddschn@users.noreply.github.com>
kemingy
requested changes
May 24, 2023
Co-authored-by: Keming <kemingy94@gmail.com>
Signed-off-by: Teddy Xinyuan Chen <45612704+tddschn@users.noreply.github.com>
kemingy
reviewed
May 24, 2023
kemingy
reviewed
May 24, 2023
Signed-off-by: Teddy Xinyuan Chen <45612704+tddschn@users.noreply.github.com>
Signed-off-by: Teddy Xinyuan Chen <45612704+tddschn@users.noreply.github.com>
Signed-off-by: Teddy Xinyuan Chen <45612704+tddschn@users.noreply.github.com>
|
how do I mark this PR as blocked by tensorchord/llmspec#27 ? https://stackoverflow.com/questions/26619478/are-dependent-pull-requests-in-github-possible I don't think github support this at this time. |
Signed-off-by: Teddy Xinyuan Chen <45612704+tddschn@users.noreply.github.com>
|
Can you resolve the conflicts? |
kemingy
force-pushed
the
mainpy-embedding-support
branch
from
d86d442
to
1104c0b
Compare
|
Merging this since it blocks the progress. Will refactor it later. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #14