Skip to content
This repository has been archived by the owner on Jul 17, 2024. It is now read-only.

feat: support delete node #146

Merged
merged 3 commits into from
Aug 14, 2023
Merged

feat: support delete node #146

merged 3 commits into from
Aug 14, 2023

Conversation

kemingy
Copy link
Member

@kemingy kemingy commented Aug 10, 2023

Signed-off-by: Keming <kemingyang@tensorchord.ai>
@kemingy
Copy link
Member Author

kemingy commented Aug 10, 2023

cc @gaocegege

@gaocegege
Copy link
Member

Test failed.

BTW, please run go run ./hack/cli-doc-gen/main.go to generate the doc.

Signed-off-by: Keming <kemingyang@tensorchord.ai>
@kemingy
Copy link
Member Author

kemingy commented Aug 11, 2023

Test failed.

BTW, please run go run ./hack/cli-doc-gen/main.go to generate the doc.

Updated.

The test will fail because the agent is using the old version.

cc @zwpaper

@zwpaper
Copy link
Member

zwpaper commented Aug 11, 2023

@kemingy sorry for the later reply, created a issue, let's discuss it here #147

@kemingy kemingy linked an issue Aug 12, 2023 that may be closed by this pull request
@kemingy kemingy merged commit b82fda1 into tensorchord:main Aug 14, 2023
3 checks passed
@kemingy kemingy deleted the delete_node branch August 14, 2023 03:01
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Panic when start server feat: Support remove a node from the cluster
3 participants