This repository has been archived by the owner on Jul 17, 2024. It is now read-only.
chore: Fix nginx rewrite path error when create deployment via BYOC #188
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: xieydd <xieydd@gmail.com>
cutecutecat
reviewed
Oct 10, 2023
| annotations["nginx.ingress.kubernetes.io/rewrite-target"] = "/inference/" + fni.Name + "." + inferenceNamespace + "/$1" | ||
| annotations["nginx.ingress.kubernetes.io/ssl-redirect"] = "false" | ||
| annotations["nginx.ingress.kubernetes.io/use-regex"] = "true" | ||
| // for inference created by modelz apiserver |
There was a problem hiding this comment.
Is this designed for BYOC created inference when INGRESS_OPERATOR_SERVICE_HOST might be not be apiserver?
There was a problem hiding this comment.
If you set INGRESS_OPERATOR_SERVICE_HOST be apiserver, you can not use mdz create inference in local environment.
xieydd
added
do-not-merge/work-in-progress
and removed
do-not-merge/work-in-progress
labels
|
|
|
Yeah I think so. |
So I think we still need to keep |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.