-
Notifications
You must be signed in to change notification settings - Fork 610
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix condition tracing in scale_channel #1830
Conversation
You are owner of some files modified in this pull request. |
Thanks! Tracing the encapsulated function appears to work: Would very much like the standardize the testing for tf.data.Dataset on tfa.image with #992 |
@seanpmorgan I don't know if in the original colab example, the one with |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Many thanks for the quick fix :-) Could we add a simple testcase about tf.data.Dataset
? Thanks.
I think that we have a more general issue here about |
Could you give me the link to the issue about |
doesn't trace
it works |
We had some previous issues with But seems that they have not tested entering in |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Got it! Then I think we could merge this :-) Thanks for the contribution and clarification!
If you are interested I am tying to check if |
Try to fix #1829