Standardized Testing Module #2233
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…sting. refactored standardized test for optimizers to import from the new module.
|
@seanpmorgan please review the refactoring |
WindQAQ
reviewed
Nov 23, 2020
| @@ -18,7 +18,7 @@ | |||
| import tensorflow as tf | |||
There was a problem hiding this comment.
Why the file name is changed from standard_test to standard_tests?
There was a problem hiding this comment.
I think I changed it because there would be multiple tests? We can change it back?
There was a problem hiding this comment.
Let's change it back. I think it's better to have a standard naming convention for file!
jrruijli
pushed a commit
to jrruijli/addons
that referenced
this pull request
Dec 23, 2020
* refactored discover classes method to the utils.tests.standardized_testing. refactored standardized test for optimizers to import from the new module. * refactored to remove useless extra file * fixed errors * renamed file
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See #992
This refactors a previous commit to make the discover classes function accessible to other modules for the creation of future standardized testing of classes within a module