Adding sample weight and keras test to R-Square #564
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
seanpmorgan
requested changes
Oct 23, 2019
There was a problem hiding this comment.
Thanks @SSaishruthi looks good! Please see the attached comments.
Comment on lines
-84
to
-85
| if __name__ == '__main__': | ||
| tf.test.main() |
| @@ -51,7 +51,7 @@ def __init__(self, name='r_square', dtype=tf.float32): | |||
| self.res = self.add_weight("residual", initializer="zeros") | |||
| self.count = self.add_weight("count", initializer="zeros") | |||
|
|
|||
| def update_state(self, y_true, y_pred): | |||
| def update_state(self, y_true, y_pred, sample_weight=None): | |||
There was a problem hiding this comment.
I believe sample_weight needs to be applied? See https://github.com/tensorflow/tensorflow/blob/r2.0/tensorflow/python/keras/metrics.py#L317-L329
There was a problem hiding this comment.
For now, we are adding it to be done. Will create a new PR with implementation for the same.
|
I'll close this pull request as it has been inactive for a while now. Feel free to comment if you want me to reopen the pull request. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added:
Sample Weightparameter@Squadrick Can you please take a look at it?