[GSoC] TF 2.0 Mask R-CNN #78

Vishal-V · 2019-07-22T17:54:21Z

TF 2.0 compatible Mask R-CNN model adapted from the Matterport implementation.
Performance improvements with lesser parameters and improved residual blocks.
Parallelized training with GPUs and an assortment of utils for various use cases.
Associated Migration guide for the Tensorflow 2.0 specific changes.
Runner script to run the model and draw inferences form the pre-trained COCO weights.

MarkDaoust

This looks great, I'll need to go through it in more detail.

Two top level comments:

-We need to make sure we handle the "adapted from" correctly.

-(optional) It would be nice if you had a notebook version of the driver script.

MarkDaoust · 2019-07-29T23:58:47Z

tensorflow_examples/models/mask_rcnn/model.py

+
+Reference:
+[Mask R-CNN](https://arxiv.org/asb/1703.06870)
+


These "adapted form" make me a little nervous.

I'll need to check and make sure we attribute this properly.

MarkDaoust · 2019-07-30T00:00:59Z

tensorflow_examples/models/mask_rcnn/main.py

+	text = "{}: {:.3f}".format(label, score)
+	y = startY - 10 if startY - 10 > 10 else startY + 10
+	cv2.putText(image, text, (startX, y), cv2.FONT_HERSHEY_SIMPLEX, 0.6, color, 2)
+


A driver script should use if __name__=="__main__":

yashk2810 · 2019-07-30T18:43:04Z

tensorflow_examples/models/mask_rcnn/model.py

+#  Utility Functions
+############################################################
+
+def log(text, array=None):


This file is huge. Can you break this up?

For example, putting utility functions in utils.py, model in models.py, training in train.py, etc

Also, is it possible to add MirroredStrategy (https://www.tensorflow.org/versions/r2.0/api_docs/python/tf/distribute/MirroredStrategy) to this model?

Vishal-V added 3 commits July 22, 2019 23:15

Added config files

d910609

Added Mask R-CNN model

905dcc2

Added Runner script

86d273f

googlebot added the cla: yes CLA has been signed label Jul 22, 2019

MarkDaoust reviewed Jul 30, 2019

View reviewed changes

yashk2810 reviewed Jul 30, 2019

View reviewed changes

Added setup and updated attributions

e0213e0

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[GSoC] TF 2.0 Mask R-CNN #78

[GSoC] TF 2.0 Mask R-CNN #78

Vishal-V commented Jul 22, 2019

MarkDaoust left a comment

MarkDaoust Jul 29, 2019

MarkDaoust Jul 30, 2019

yashk2810 Jul 30, 2019


		Reference:
		[Mask R-CNN](https://arxiv.org/asb/1703.06870)

[GSoC] TF 2.0 Mask R-CNN #78

Are you sure you want to change the base?

[GSoC] TF 2.0 Mask R-CNN #78

Conversation

Vishal-V commented Jul 22, 2019

MarkDaoust left a comment

Choose a reason for hiding this comment

MarkDaoust Jul 29, 2019

Choose a reason for hiding this comment

MarkDaoust Jul 30, 2019

Choose a reason for hiding this comment

yashk2810 Jul 30, 2019

Choose a reason for hiding this comment