-
Notifications
You must be signed in to change notification settings - Fork 124
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix compatibility with latest 'stable' flutter build + bump min sdk to 3.3.0 #233
Conversation
Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA). View this failed invocation of the CLA check for more information. For the most up to date status, view the checks section at the bottom of the pull request. |
Let me check to see how many devs are using 3.3.0 or later, but if it's a decent number then this seems reasonable. |
Also looks like this just needs a quick format check |
Alright if you can just run the format command (I want to say it was |
done :) |
This one might take a minute to get into the full package. Fighting ffigen and building with error messages around |
dude i love u |
@PaulTR ill try and take a look if i can figure something out :) |
Will there be a new version that makes this fix available to everyone? |
The latest Flutter Version broke this package (see #232). This PR restores functionality with the downside of bumping the minimum dart sdk to 3.3.0.
If that is too harsh and there is a better solution, feel free to decline, I won't mind :)