Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix compatibility with latest 'stable' flutter build + bump min sdk to 3.3.0 #233

Merged
merged 2 commits into from
Jul 31, 2024

Conversation

ptgms
Copy link
Contributor

@ptgms ptgms commented Jul 25, 2024

The latest Flutter Version broke this package (see #232). This PR restores functionality with the downside of bumping the minimum dart sdk to 3.3.0.

If that is too harsh and there is a better solution, feel free to decline, I won't mind :)

Copy link

google-cla bot commented Jul 25, 2024

Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

View this failed invocation of the CLA check for more information.

For the most up to date status, view the checks section at the bottom of the pull request.

@PaulTR
Copy link
Collaborator

PaulTR commented Jul 30, 2024

Let me check to see how many devs are using 3.3.0 or later, but if it's a decent number then this seems reasonable.

@PaulTR
Copy link
Collaborator

PaulTR commented Jul 30, 2024

Also looks like this just needs a quick format check

@PaulTR
Copy link
Collaborator

PaulTR commented Jul 30, 2024

Alright if you can just run the format command (I want to say it was dart format --output=none --set-exit-if-changed .) this should be good to go - upping the version seems like a good plan on my side.

@ptgms
Copy link
Contributor Author

ptgms commented Jul 31, 2024

done :)

@PaulTR PaulTR merged commit 83a2013 into tensorflow:main Jul 31, 2024
1 of 2 checks passed
@PaulTR
Copy link
Collaborator

PaulTR commented Jul 31, 2024

This one might take a minute to get into the full package. Fighting ffigen and building with error messages around error - lib/src/bindings/tensorflow_lite_bindings_generated.dart:2060:7 - The type 'TfLiteModel' must be 'base', 'final' or 'sealed' because the supertype 'Opaque' is 'base'. - subtype_of_base_or_final_is_not_base_final_or_sealed - figuring out what needs to be changed to pass that via flutter pub run ffigen --config ffigen_tensorflow_lite.yaml

@andresgd7
Copy link

dude i love u

@ptgms
Copy link
Contributor Author

ptgms commented Aug 3, 2024

@PaulTR ill try and take a look if i can figure something out :)
lets get this fixed so our developer friends can start using this package again :)

@SametSahin10
Copy link

Will there be a new version that makes this fix available to everyone?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants