Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: final class for tflite bindings #241

Merged
merged 3 commits into from
Sep 3, 2024

Conversation

mdejeans
Copy link
Contributor

@mdejeans mdejeans commented Aug 14, 2024

Fix #234
Upgraded ffigen, melos, flutter lint + add some help in read me using melos.

  ffigen: ^10.0.0
  flutter_lints: ^4.0.0
  melos: ^6.1.0

We can probably bump ffigen further thanks to #244

Copy link

google-cla bot commented Aug 14, 2024

Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

View this failed invocation of the CLA check for more information.

For the most up to date status, view the checks section at the bottom of the pull request.

@PaulTR
Copy link
Collaborator

PaulTR commented Aug 15, 2024

So that's actually a generated class :) When we run the ffi script (https://github.com/tensorflow/flutter-tflite/blob/main/ffigen_tensorflow_lite.yaml) this gets overridden.

@s12dar
Copy link

s12dar commented Aug 19, 2024

@PaulTR, I wonder if there is an estimated timeline for when the tflite_flutter package will be updated to address the recent issues with the Dart upgrade?

@craiglabenz
Copy link
Collaborator

This should be a matter updating all the dependencies everywhere. What's happening is that ffigen is generating newer code than other aspects of the pubspec.yaml file are cool with.

@chathurach
Copy link

We can update the ffigen package to 8.0.0 and resolve this issue. This issue has been resolved after 8.0.0 version. https://pub.dev/packages/ffigen/changelog

@mdejeans mdejeans marked this pull request as ready for review September 2, 2024 17:28
@mdejeans
Copy link
Contributor Author

mdejeans commented Sep 2, 2024

@PaulTR @chathurach gotcha!

Copy link
Collaborator

@craiglabenz craiglabenz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@PaulTR PaulTR merged commit 351225d into tensorflow:main Sep 3, 2024
2 checks passed
@mdejeans mdejeans deleted the fix_class_opaque branch September 3, 2024 15:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
5 participants